116 lines
3.1 KiB
Diff
116 lines
3.1 KiB
Diff
|
From 0046ef0e85ea94f959c2a11df2e7cbbc8c06cf03 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Thomas Gleixner <tglx@linutronix.de>
|
||
|
|
Date: Thu, 15 Jul 2010 10:29:00 +0200
|
||
|
|
Subject: [PATCH 059/365] suspend: Prevent might sleep splats
|
||
|
|
|
||
|
|
timekeeping suspend/resume calls read_persistant_clock() which takes
|
||
|
|
rtc_lock. That results in might sleep warnings because at that point
|
||
|
|
we run with interrupts disabled.
|
||
|
|
|
||
|
|
We cannot convert rtc_lock to a raw spinlock as that would trigger
|
||
|
|
other might sleep warnings.
|
||
|
|
|
||
|
|
As a temporary workaround we disable the might sleep warnings by
|
||
|
|
setting system_state to SYSTEM_SUSPEND before calling sysdev_suspend()
|
||
|
|
and restoring it to SYSTEM_RUNNING afer sysdev_resume().
|
||
|
|
|
||
|
|
Needs to be revisited.
|
||
|
|
|
||
|
|
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
|
||
|
|
---
|
||
|
|
include/linux/kernel.h | 1 +
|
||
|
|
kernel/power/hibernate.c | 7 +++++++
|
||
|
|
kernel/power/suspend.c | 4 ++++
|
||
|
|
3 files changed, 12 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
|
||
|
|
index 3cf6a1e5e6f2..b15c8c52f386 100644
|
||
|
|
--- a/include/linux/kernel.h
|
||
|
|
+++ b/include/linux/kernel.h
|
||
|
|
@@ -490,6 +490,7 @@ extern enum system_states {
|
||
|
|
SYSTEM_HALT,
|
||
|
|
SYSTEM_POWER_OFF,
|
||
|
|
SYSTEM_RESTART,
|
||
|
|
+ SYSTEM_SUSPEND,
|
||
|
|
} system_state;
|
||
|
|
|
||
|
|
#define TAINT_PROPRIETARY_MODULE 0
|
||
|
|
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
|
||
|
|
index 7b393faf930f..73ddd8143753 100644
|
||
|
|
--- a/kernel/power/hibernate.c
|
||
|
|
+++ b/kernel/power/hibernate.c
|
||
|
|
@@ -291,6 +291,8 @@ static int create_image(int platform_mode)
|
||
|
|
|
||
|
|
local_irq_disable();
|
||
|
|
|
||
|
|
+ system_state = SYSTEM_SUSPEND;
|
||
|
|
+
|
||
|
|
error = syscore_suspend();
|
||
|
|
if (error) {
|
||
|
|
printk(KERN_ERR "PM: Some system devices failed to power down, "
|
||
|
|
@@ -322,6 +324,7 @@ static int create_image(int platform_mode)
|
||
|
|
syscore_resume();
|
||
|
|
|
||
|
|
Enable_irqs:
|
||
|
|
+ system_state = SYSTEM_RUNNING;
|
||
|
|
local_irq_enable();
|
||
|
|
|
||
|
|
Enable_cpus:
|
||
|
|
@@ -455,6 +458,7 @@ static int resume_target_kernel(bool platform_mode)
|
||
|
|
goto Enable_cpus;
|
||
|
|
|
||
|
|
local_irq_disable();
|
||
|
|
+ system_state = SYSTEM_SUSPEND;
|
||
|
|
|
||
|
|
error = syscore_suspend();
|
||
|
|
if (error)
|
||
|
|
@@ -488,6 +492,7 @@ static int resume_target_kernel(bool platform_mode)
|
||
|
|
syscore_resume();
|
||
|
|
|
||
|
|
Enable_irqs:
|
||
|
|
+ system_state = SYSTEM_RUNNING;
|
||
|
|
local_irq_enable();
|
||
|
|
|
||
|
|
Enable_cpus:
|
||
|
|
@@ -573,6 +578,7 @@ int hibernation_platform_enter(void)
|
||
|
|
goto Enable_cpus;
|
||
|
|
|
||
|
|
local_irq_disable();
|
||
|
|
+ system_state = SYSTEM_SUSPEND;
|
||
|
|
syscore_suspend();
|
||
|
|
if (pm_wakeup_pending()) {
|
||
|
|
error = -EAGAIN;
|
||
|
|
@@ -585,6 +591,7 @@ int hibernation_platform_enter(void)
|
||
|
|
|
||
|
|
Power_up:
|
||
|
|
syscore_resume();
|
||
|
|
+ system_state = SYSTEM_RUNNING;
|
||
|
|
local_irq_enable();
|
||
|
|
|
||
|
|
Enable_cpus:
|
||
|
|
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
|
||
|
|
index 2d0c99b3f34c..880c5a2d48b9 100644
|
||
|
|
--- a/kernel/power/suspend.c
|
||
|
|
+++ b/kernel/power/suspend.c
|
||
|
|
@@ -382,6 +382,8 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
|
||
|
|
arch_suspend_disable_irqs();
|
||
|
|
BUG_ON(!irqs_disabled());
|
||
|
|
|
||
|
|
+ system_state = SYSTEM_SUSPEND;
|
||
|
|
+
|
||
|
|
error = syscore_suspend();
|
||
|
|
if (!error) {
|
||
|
|
*wakeup = pm_wakeup_pending();
|
||
|
|
@@ -401,6 +403,8 @@ static int suspend_enter(suspend_state_t state, bool *wakeup)
|
||
|
|
syscore_resume();
|
||
|
|
}
|
||
|
|
|
||
|
|
+ system_state = SYSTEM_RUNNING;
|
||
|
|
+
|
||
|
|
arch_suspend_enable_irqs();
|
||
|
|
BUG_ON(irqs_disabled());
|
||
|
|
|
||
|
|
--
|
||
|
|
2.28.0
|
||
|
|
|