From f2d67a7b326442ac173f822b73e8c3cda13f9db1 Mon Sep 17 00:00:00 2001 From: Sebastian Andrzej Siewior Date: Fri, 14 Jun 2013 17:16:35 +0200 Subject: [PATCH 281/365] kernel/hotplug: restore original cpu mask oncpu/down If a task which is allowed to run only on CPU X puts CPU Y down then it will be allowed on all CPUs but the on CPU Y after it comes back from kernel. This patch ensures that we don't lose the initial setting unless the CPU the task is running is going down. Signed-off-by: Sebastian Andrzej Siewior --- kernel/cpu.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index 1fbc7dd95ccc..072e296c1c12 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1308,6 +1308,7 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, bool hasdied = false; int mycpu; cpumask_var_t cpumask; + cpumask_var_t cpumask_org; if (num_online_cpus() == 1) return -EBUSY; @@ -1318,6 +1319,12 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, /* Move the downtaker off the unplug cpu */ if (!alloc_cpumask_var(&cpumask, GFP_KERNEL)) return -ENOMEM; + if (!alloc_cpumask_var(&cpumask_org, GFP_KERNEL)) { + free_cpumask_var(cpumask); + return -ENOMEM; + } + + cpumask_copy(cpumask_org, tsk_cpus_allowed(current)); cpumask_andnot(cpumask, cpu_online_mask, cpumask_of(cpu)); set_cpus_allowed_ptr(current, cpumask); free_cpumask_var(cpumask); @@ -1326,7 +1333,8 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, if (mycpu == cpu) { printk(KERN_ERR "Yuck! Still on unplug CPU\n!"); migrate_enable(); - return -EBUSY; + ret = -EBUSY; + goto restore_cpus; } cpu_hotplug_begin(); @@ -1380,6 +1388,9 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, /* This post dead nonsense must die */ if (!ret && hasdied) cpu_notify_nofail(CPU_POST_DEAD, cpu); +restore_cpus: + set_cpus_allowed_ptr(current, cpumask_org); + free_cpumask_var(cpumask_org); arch_smt_update(); return ret; } -- 2.28.0