wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

Fix progress percentage #100

Merged
chschu merged 1 commits from bugfix/percent-done-not-working into master 2021-04-10 17:03:40 -05:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
chschu commented 2021-03-09 17:11:22 -06:00 (Migrated from github.com)
Copy Link

Description

The final newline of the A6V response is currently not sent if a print is in progress. The progress percentage is not displayed correctly, and the next response sent to the display will be lost as well.

This PR moves the transmission of the newline out of the else branch, so it is executed for every case.

Benefits

The progress percentage is displayed correctly.

Configurations

Nothing special required.

Related Issues

None.

### Description The final newline of the A6V response is currently not sent if a print is in progress. The progress percentage is not displayed correctly, and the next response sent to the display will be lost as well. This PR moves the transmission of the newline out of the else branch, so it is executed for every case. ### Benefits The progress percentage is displayed correctly. ### Configurations Nothing special required. ### Related Issues None.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#100
No description provided.
Delete Branch "bugfix/percent-done-not-working"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?