wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

Update mesh_bed_leveling.h #394

Merged
KemalErtas merged 1 commits from patch-1 into master 2022-12-19 08:16:24 -06:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
KemalErtas commented 2022-12-01 04:16:08 -06:00 (Migrated from github.com)
Copy Link

Bedleveling should run on 4MAXP2 rectangular shape beds. It has no problem with square shape.

Description

Requirements

Benefits

Configurations

Configurations

Related Issues

Bedleveling should run on 4MAXP2 rectangular shape beds. It has no problem with square shape. <!-- Submitting a Pull Request - Please fill out all sections of this form. You can delete the helpful comments. - Pull Requests without clear information will take longer and may even be rejected. - We get a high volume of submissions so please be patient during review. --> ### Description <!-- Clearly describe the submitted changes with lots of details. Include images where helpful. Initial reviewers may not be familiar with the subject, so be as thorough as possible. You can use MarkDown syntax to improve readability with bullet lists, code blocks, and so on. PREVIEW and fix up formatting before submitting. --> ### Requirements <!-- Does this PR require a specific board, LCD, etc.? --> ### Benefits <!-- What does this PR fix or improve? --> ### Configurations <!-- Attach Configurations ZIP and any other files needed to test this PR. --> ### Configurations <!-- Attach any Configuration.h, Configuration_adv.h, or platformio.ini files needed to compile/test your Pull Request. --> ### Related Issues <!-- Does this PR fix a bug or fulfill a Feature Request? Link related Issues here. -->
stklcode commented 2022-12-19 07:30:03 -06:00 (Migrated from github.com)
Copy Link

You should probably send this patch upstream (in MarlinFirmware/Marlin). as the bug is present in the latest 2.1.x sources:

https://github.com/MarlinFirmware/Marlin/blob/2.1.2/Marlin/src/feature/bedlevel/mbl/mesh_bed_leveling.h#L112

You should probably send this patch upstream (in [MarlinFirmware/Marlin](https://github.com/MarlinFirmware/Marlin)). as the bug is present in the latest 2.1.x sources: https://github.com/MarlinFirmware/Marlin/blob/2.1.2/Marlin/src/feature/bedlevel/mbl/mesh_bed_leveling.h#L112
KemalErtas commented 2022-12-19 07:44:19 -06:00 (Migrated from github.com)
Copy Link

I will send to Marlin

I will send to Marlin
👍 2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#394
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?