use longest_filename() for SD card files instead of longFilename #398

Merged
stklcode merged 1 commits from fix/393-sd-filenames into master 2022-12-20 02:17:00 -06:00
stklcode commented 2022-12-20 02:08:28 -06:00 (Migrated from github.com)

Description

The long filename is not always filled, so files like "test.gco" may not be shown in the file list. Use the built-in fallback to the longest name available to overcome that issue and print the 8.3 name if no other is available.

Requirements

Issue was reported on a printer with DGUS2-clone display, but it should work on every supported display.

Benefits

Filenames with no long name present should be output on the display again,

image
(tested on a Mega P)

Configurations

No special config required.

#393

### Description The long filename is not always filled, so files like "test.gco" may not be shown in the file list. Use the built-in fallback to the longest name available to overcome that issue and print the 8.3 name if no other is available. ### Requirements Issue was reported on a printer with DGUS2-clone display, but it should work on every supported display. ### Benefits Filenames with no long name present should be output on the display again, ![image](https://user-images.githubusercontent.com/12963621/208615637-c14e261a-0c9b-4b55-894b-e0e25a3c085f.jpg) (tested on a _Mega P_) ### Configurations No special config required. ### Related Issues #393
stklcode commented 2022-12-20 02:10:19 -06:00 (Migrated from github.com)

cc @wes1993 @leonel85

Could you test the proposed solution on your printers to see, if we need to do additional filename trickery here?

I can provide you with hex files if necessary, just tell me which target you need.

cc @wes1993 @leonel85 Could you test the proposed solution on your printers to see, if we need to do additional filename trickery here? I can provide you with hex files if necessary, just tell me which target you need.
leonel85 commented 2022-12-20 03:53:48 -06:00 (Migrated from github.com)

@stklcode
I will compile by myself because I have my own configuration.
I will test this night

Thank's

@stklcode I will compile by myself because I have my own configuration. I will test this night Thank's
Sign in to join this conversation.
No description provided.