wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

fix regression from LCD_SERIAL migration for CHIRON targets #404

Merged
stklcode merged 1 commits from fix/chiron-regression into master 2022-12-22 02:41:35 -06:00
Conversation 0 Commits 1 Files Changed 2 +3 -8
stklcode commented 2022-12-22 02:40:09 -06:00 (Migrated from github.com)
Copy Link

Description

Fixes a regression from fd58245bd2.

There is an extension to the G29 implementation that sends a J25 notification to the external display. This must not use the HardwareSerial implementation anymore.

there are also two leftover opening parenthesis in the command scanning loop within the Chiron block that must be removed.

Requirements

Affects CHIRON, CHIRON_TMC, CHIRON_DGUS and CHIRON_DGUS_TMC environments.

Benefits

The firmware compiles and should work again.

Configurations

--

Related Issues

--

### Description Fixes a regression from fd58245bd2b1f89ab1f6ce0f9582d44369a3ce68. There is an extension to the G29 implementation that sends a `J25` notification to the external display. This must not use the _HardwareSerial_ implementation anymore. there are also two leftover opening parenthesis in the command scanning loop within the _Chiron_ block that must be removed. ### Requirements Affects `CHIRON`, `CHIRON_TMC`, `CHIRON_DGUS` and `CHIRON_DGUS_TMC` environments. ### Benefits The firmware compiles and should work again. ### Configurations -- ### Related Issues --
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#404
No description provided.
Delete Branch "fix/chiron-regression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?