wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

[BUG] Bad Code for Wi-Fi in firmware #406

New Issue
Closed
opened 2022-12-22 05:41:54 -06:00 by wes1993 · 3 comments
wes1993 commented 2022-12-22 05:41:54 -06:00 (Migrated from github.com)
Copy Link

Bug Description

The code related to the SERIAL_PORT_2 is different from the wiki, is normal?

Steps to Reproduce

Check the code

Expected behavior:
Should be:

#define SERIAL_PORT_2 2
#define BAUDRATE_2 500000 // :[2400, 9600, 19200, 38400, 57600, 115200, 250000, 500000, 1000000] Enable to override BAUDRATE

Actual behavior:
Now is:
#define SERIAL_PORT_2 -1
#define BAUDRATE_2 250000 // :[2400, 9600, 19200, 38400, 57600, 115200, 250000, 500000, 1000000] Enable to override BAUDRATE

Additional Information

None....

### Bug Description The code related to the SERIAL_PORT_2 is different from the wiki, is normal? ### Steps to Reproduce Check the code **Expected behavior:** Should be: #define SERIAL_PORT_2 2 #define BAUDRATE_2 500000 // :[2400, 9600, 19200, 38400, 57600, 115200, 250000, 500000, 1000000] Enable to override BAUDRATE **Actual behavior:** Now is: #define SERIAL_PORT_2 -1 #define BAUDRATE_2 250000 // :[2400, 9600, 19200, 38400, 57600, 115200, 250000, 500000, 1000000] Enable to override BAUDRATE #### Additional Information None....
knutwurst commented 2022-12-22 05:49:37 -06:00 (Migrated from github.com)
Copy Link

@wes1993
You are absolutely right. Some changes made when updating to the Marlin upstream version have overwritten these values.

@wes1993 You are absolutely right. Some changes made when updating to the Marlin upstream version have overwritten these values.
stklcode commented 2022-12-22 07:51:35 -06:00 (Migrated from github.com)
Copy Link

Yep, sorry for that.

Both lines are commented out by default, i.e. don't have any effect on the outcome, so I didn't care about them here.

c9f1b91bbe/Marlin/Configuration.h (L214-L215)

Yep, sorry for that. Both lines are commented out by default, i.e. don't have any effect on the outcome, so I didn't care about them here. https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/blob/c9f1b91bbe6afc88e0305d5421b94b3a726ace9f/Marlin/Configuration.h#L214-L215
github-actions[bot] commented 2023-02-20 08:03:36 -06:00 (Migrated from github.com)
Copy Link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#406
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?