wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

use static initialization for output string in RenderCurrentFolder #473

Merged
stklcode merged 1 commits from fix/render-current-folder into master 2023-06-24 05:50:47 -05:00
Conversation 1 Commits 1 Files Changed 1 +15 -19
stklcode commented 2023-06-24 05:31:16 -05:00 (Migrated from github.com)
Copy Link

Description

The dynamic sized variable outputString may not be properly initialized.

Second issue, we fill the line for directories beyond fileNameLength, so the initialization is not always sufficient.

00a74c15eb/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.cpp (L912-L916)

In this case, fileNameWasCut == false, so fileNameLen < MAX_PRINTABLE_FILENAME_LEN and we declared outputString[fileNameLen].
So if fileNameLen > MAX_PRINTABLE_FILENAME_LEN - 7 we write beyond the array bounds.

Resolution

We now initialize outputString statically with the maximum printable size which should resolve both.

Also clean up some variable declarations.

Requirements

The described bug only affects targets with KNUTWURST_DGUS2_TFT.

The static initialization affects all targets.

Benefits

Resolves potential memory issues during file list rendering.

Configurations

none

Related Issues

none

### Description The dynamic sized variable `outputString` may not be properly initialized. Second issue, we fill the line for directories beyond `fileNameLength`, so the initialization is not always sufficient. https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/blob/00a74c15ebbb5f42076be3717b50162378733262/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.cpp#L912-L916 In this case, `fileNameWasCut == false`, so `fileNameLen < MAX_PRINTABLE_FILENAME_LEN` and we declared `outputString[fileNameLen]`. So if `fileNameLen > MAX_PRINTABLE_FILENAME_LEN - 7` we write beyond the array bounds. **Resolution** We now initialize `outputString` statically with the maximum printable size which should resolve both. Also clean up some variable declarations. ### Requirements The described bug only affects targets with `KNUTWURST_DGUS2_TFT`. The static initialization affects all targets. ### Benefits Resolves potential memory issues during file list rendering. ### Configurations none ### Related Issues none
knutwurst commented 2023-06-24 05:50:41 -05:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#473
No description provided.
Delete Branch "fix/render-current-folder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?