[BUG] "Hotend temperature abnormal" warning never actually triggered #475

New Issue

2023-06-24T07:56:36-05:00

stklcode commented

2023-06-24 07:56:36 -05:00

(Migrated from github.com)

Bug Description

We have a routine to check for heater errors using a timeout counter that is incremented if the temperature is out of range:

0981430d4b/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.cpp (L982-L984)

The counter condition will never be true, because HeaterCheckCount is declared uint16_t which is bound to [0, 65535].

0981430d4b/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.h (L230)

Steps to Reproduce

Let the printer under- or overheat
Wait some time

(no, you should probably not try this at home 😉)

Expected behavior: An error "Hotend temperature abnormal..." should pop up.

Actual behavior: Nothing.

(no, I did not test this for real, but the behavior should be pretty straight forward from the code)

Additional Information

--

Question

600.000 is pretty high. This was actually increased from 60.000 in 85bac6b396

Should we lower the limit again or increase the counter size to uint32_t or similar?

### Bug Description We have a routine to check for heater errors using a timeout counter that is incremented if the temperature is out of range: https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/blob/0981430d4be596ba4cc767ab4126921868ddb988/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.cpp#L982-L984 The counter condition will never be true, because `HeaterCheckCount` is declared `uint16_t` which is bound to `[0, 65535]`. https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/blob/0981430d4be596ba4cc767ab4126921868ddb988/Marlin/src/lcd/extui/knutwurst/anycubic_touchscreen.h#L230 ### Steps to Reproduce 1. Let the printer under- or overheat 2. Wait some time (no, you should probably not try this at home :wink:) **Expected behavior:** An error "Hotend temperature abnormal..." should pop up. **Actual behavior:** Nothing. (no, I did not test this for real, but the behavior should be pretty straight forward from the code) #### Additional Information -- ### Question 600.000 is pretty high. This was actually increased from 60.000 in 85bac6b3960966b49f23a694cf75562842f26e80 Should we lower the limit again or increase the counter size to `uint32_t` or similar?

knutwurst commented

2023-06-24 08:17:57 -05:00

(Migrated from github.com)

To be honest - I don't know why I increased the heater check count.
Maybe it's a good Idea to lower it an test everything.

To be honest - I don't know why I increased the heater check count. Maybe it's a good Idea to lower it an test everything.

github-actions[bot] commented

2024-04-19 20:25:02 -05:00

(Migrated from github.com)

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#475