wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

swap Z motors for all targets and use predefined mappings #401

Merged
stklcode merged 1 commits from fix/z-mapping into master 2022-12-21 14:40:29 -06:00
Conversation 0 Commits 1 Files Changed 2 +11 -2
stklcode commented 2022-12-21 12:58:55 -06:00 (Migrated from github.com)
Copy Link

Description

Z endstop mapping has changed as side effect of the upstream merge, so it does no longer match the motor mapping.
Define SWAP_Z_MOTORS to resolve this issue without manipulation of the upstream pin mapping.

Also use predefined mapping (TRIGORILLA_MAPPING_CHIRON and TRIGORILLA_MAPPING_I3MEGA) instead of custom overrides in the pins_TRIGORILLA_14.h.

I discovered this issue on a Mega P, not tested for other targets.

Requirements

Changes affect all targets.

Benefits

misaligned Z axis does not crash anymore.

Configurations

--

Related Issues

--

### Description Z endstop mapping has changed as side effect of the upstream merge, so it does no longer match the motor mapping. Define _SWAP_Z_MOTORS_ to resolve this issue without manipulation of the upstream pin mapping. Also use predefined mapping (`TRIGORILLA_MAPPING_CHIRON` and `TRIGORILLA_MAPPING_I3MEGA`) instead of custom overrides in the _pins_TRIGORILLA_14.h_. **I discovered this issue on a Mega P, not tested for other targets.** ### Requirements Changes affect all targets. ### Benefits misaligned Z axis does not crash anymore. ### Configurations -- ### Related Issues --
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#401
No description provided.
Delete Branch "fix/z-mapping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?