WIP: Klicky Probe #461

2023-05-25T05:37:20-05:00

sui77 commented

2023-05-25 05:37:20 -05:00

(Migrated from github.com)

Description

Enables the use of a DIY magnetic mounted (aka "klicky") probe. It basically already works (preview video) but is still a work in progress. I need to refine STLs that I intend to publish on printables, write instructions and fine tune deploy&stow movements. I'd prefer to link to this well known repository instead of maintaining a fork, so if this comes into question I kindly ask you to do a first quick review before I go on.

Requirements

A klicky probe that consists of 4x1mm magnets, a limit switch and these STLs https://github.com/sui77/3d-printing/tree/master/klicky/stl that fit on a [MK4] carriage. Wiring is same as BLTOUCH except it doesn't utilize a servo.

Configurations

At this point I've added these environments: MEGA_TMC_KLICKY and MEGA_S_TMC_KLICKY

### Description Enables the use of a DIY magnetic mounted (aka "klicky") probe. It basically already works ([preview video](https://www.youtube.com/watch?v=kNe3XqS_uH0)) but is still a work in progress. I need to refine STLs that I intend to publish on printables, write instructions and fine tune deploy&stow movements. I'd prefer to link to this well known repository instead of maintaining a fork, so if this comes into question I kindly ask you to do a first quick review before I go on. ### Requirements A klicky probe that consists of 4x1mm magnets, a limit switch and these STLs https://github.com/sui77/3d-printing/tree/master/klicky/stl that fit on a [MK4] carriage. Wiring is same as BLTOUCH except it doesn't utilize a servo. ### Configurations At this point I've added these environments: MEGA_TMC_KLICKY and MEGA_S_TMC_KLICKY

knutwurst commented

2023-05-28 11:21:10 -05:00

(Migrated from github.com)

I like the idea and your implementation looks very solid. Glad you followed the guidelines and added a new build environment. :)

However, I see some minor problems here:

So far I don't know anyone who uses this kind of probe except you.
The two new environments are only available for the Mega and Mega S with TMC drivers, but no other combinations (without TMC or Mega Pro, Mega X etc).
I'm trying not to include any more configurations for the supported printers as we're already on a release of 50 assets.

My suggestion:
You waive the environments for the Mega and Mega S, but only adopt the new KNUTWURST_CLICKY build flag. Then you can easily add the functionality if you compile the firmware yourself. Only finished binaries will not exist then.

I understand your intention to always get the firmware for your printer from this source, but I'm afraid that in this absolute special case a fork is the better choice.

I like the idea and your implementation looks very solid. Glad you followed the guidelines and added a new build environment. :) However, I see some minor problems here: 1. So far I don't know anyone who uses this kind of probe except you. 2. The two new environments are only available for the Mega and Mega S with TMC drivers, but no other combinations (without TMC or Mega Pro, Mega X etc). 3. I'm trying not to include any more configurations for the supported printers as we're already on a release of 50 assets. My suggestion: You waive the environments for the Mega and Mega S, but only adopt the new KNUTWURST_CLICKY build flag. Then you can easily add the functionality if you compile the firmware yourself. Only finished binaries will not exist then. I understand your intention to always get the firmware for your printer from this source, but I'm afraid that in this absolute special case a fork is the better choice.

This pull request has changes conflicting with the target branch.

Marlin/Configuration.h
Marlin/src/pins/pins.h
platformio.ini

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin sui77/klicky:sui77/klicky

git checkout sui77/klicky

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#461