wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

fix manual leveling from Mega P TFT #509

Merged
stklcode merged 1 commits from fix/mega-p-leveling into master 2024-01-11 15:11:15 -06:00
Conversation 0 Commits 1 Files Changed 1 +21 -13
stklcode commented 2024-01-11 13:04:04 -06:00 (Migrated from github.com)
Copy Link

Description

Since 1.5.2 the manual leveling feature from the Mega P display is broken.

Steps to reproduce:

  • go to Setup > Leveling
  • (printer performs homing of all axes)
  • select "Next"

Expected behavior:

  • Head moves to the first/second/... leveling point

Actual behavior:

  • Minimal movement and then motors block and stop moving

Apparently this is a regression from commit 524d6fbcdf

Multiple consecutive enqueue_now_P() calls work fine, while multiple injectCommands() overwrite the previous commands instead of queuing them, so the the execution is messed up.

Injecting a single, multi-line string instead of 3 single commands works fine again.

Build and run tested on MEGA_P_DGUS_BLT_10.

Requirements

Anycubic Mega P.

Benefits

Manual leveling feature from the built-in TFT menu works again.

Configurations

--

Related Issues

#519

### Description Since 1.5.2 the manual leveling feature from the Mega P display is broken. Steps to reproduce: * go to Setup > Leveling * (printer performs homing of all axes) * select "Next" Expected behavior: * Head moves to the first/second/... leveling point Actual behavior: * Minimal movement and then motors block and stop moving Apparently this is a regression from commit 524d6fbcdfbce789b22320e25ed5b09c4dd5c42a Multiple consecutive `enqueue_now_P()` calls work fine, while multiple `injectCommands()` overwrite the previous commands instead of queuing them, so the the execution is messed up. Injecting a single, multi-line string instead of 3 single commands works fine again. Build and run tested on `MEGA_P_DGUS_BLT_10`. ### Requirements Anycubic Mega P. ### Benefits Manual leveling feature from the built-in TFT menu works again. ### Configurations -- ### Related Issues #519
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#509
No description provided.
Delete Branch "fix/mega-p-leveling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?