wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

fix: ignored z endstop when single z endstop is used #529

Merged
hostops merged 1 commits from fix/ignored-z-endstop into master 2024-04-16 14:37:09 -05:00
Conversation 2 Commits 1 Files Changed 1 +3 -1
hostops commented 2024-04-16 14:18:03 -05:00 (Migrated from github.com)
Copy Link

Description

I noticed zstop is not working in my MEGA_1G_BLT_10 after I flashed original version.
I found a bug and fixed it.
Probably this PR also fixes this issue: https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/issues/510

For TRIGORILLA_MAPPING_I3MEGA original code redefined Z_STOP_PIN to 43 which overrode original pin 18 (which is used as Z2_STOP_PIN in other boards).
I just excluded KNUTWURST_ONE_Z_ENDSTOP from override.

Requirements

MEGA_1G with only one z endstop.

Benefits

Fixes bug that makes this software unusable for MEGA_1G boards

Configurations

/

Related Issues

https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/issues/510

### Description I noticed zstop is not working in my MEGA_1G_BLT_10 after I flashed original version. I found a bug and fixed it. Probably this PR also fixes this issue: https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/issues/510 For TRIGORILLA_MAPPING_I3MEGA original code redefined Z_STOP_PIN to 43 which overrode original pin 18 (which is used as Z2_STOP_PIN in other boards). I just excluded KNUTWURST_ONE_Z_ENDSTOP from override. ### Requirements MEGA_1G with only one z endstop. ### Benefits Fixes bug that makes this software unusable for MEGA_1G boards ### Configurations / ### Related Issues https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/issues/510
knutwurst (Migrated from github.com) reviewed 2024-04-16 14:18:03 -05:00
knutwurst commented 2024-04-16 14:37:30 -05:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
knutwurst
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#529
No description provided.
Delete Branch "fix/ignored-z-endstop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?