wp/Marlin-2-0-x-Anycubic-i3-MEGA-S
1
0
Fork 0
Code Issues 28 Pull Requests 2 Actions Packages Projects Releases 30 Wiki Activity

New Special Menus Added for 4MAX+BLTouch Builds - how can I cancel this ... I thought I was making changes offline after forking using VS ... sorry ... need help #563

Closed
dennislia wants to merge 1 commits from master-dsl into master
pull from: master-dsl
merge into: wp:master
Conversation 3 Commits 1 Files Changed 6 +854 -449
dennislia commented 2025-01-09 20:44:23 -06:00 (Migrated from github.com)
Copy Link

Description

Requirements

Benefits

Configurations

Related Issues

<!-- Submitting a Pull Request - Please fill out all sections of this form. You can delete the helpful comments. - Pull Requests without clear information will take longer and may even be rejected. - We get a high volume of submissions so please be patient during review. --> ### Description <!-- Clearly describe the submitted changes with lots of details. Include images where helpful. Initial reviewers may not be familiar with the subject, so be as thorough as possible. You can use MarkDown syntax to improve readability with bullet lists, code blocks, and so on. PREVIEW and fix up formatting before submitting. --> ### Requirements <!-- Does this PR require a specific board, LCD, etc.? --> ### Benefits <!-- What does this PR fix or improve? --> ### Configurations <!-- Attach Configurations ZIP and any other files needed to test this PR. --> ### Related Issues <!-- Does this PR fix a bug or fulfill a Feature Request? Link related Issues here. -->
knutwurst commented 2025-01-10 01:17:37 -06:00 (Migrated from github.com)
Copy Link

It's no problem at all. I'm happy when someone is working on it. Your idea is good and when you're finished, I would be honored to adopt your changes if you want to :)

Otherwise, you can simply not merge to the upstream, but instead just create a branch with your new feature in your fork, for example. As long as you don't merge it to the upstream, nobody will notice and the changes will only be in your Github repo.

Here are two small overviews of how pull requests work:

https://medium.com/@18bhavyasharma/how-to-fork-modify-and-create-pull-requests-on-github-242a02c49821

https://gun.io/news/2024/11/a-complete-guide-to-github-forks-from-setup-to-pull-requests/

It's no problem at all. I'm happy when someone is working on it. Your idea is good and when you're finished, I would be honored to adopt your changes if you want to :) Otherwise, you can simply not merge to the upstream, but instead just create a branch with your new feature in your fork, for example. As long as you don't merge it to the upstream, nobody will notice and the changes will only be in your Github repo. Here are two small overviews of how pull requests work: https://medium.com/@18bhavyasharma/how-to-fork-modify-and-create-pull-requests-on-github-242a02c49821 https://gun.io/news/2024/11/a-complete-guide-to-github-forks-from-setup-to-pull-requests/
dennislia commented 2025-01-10 10:29:00 -06:00 (Migrated from github.com)
Copy Link

Oliver,Thanks.I will review the links you sent and attempt to create a new branch with my changes and let you know when I've tested it.Best regards,...DennyOn Jan 10, 2025, at 2:17 AM, Oliver Köster @.> wrote:
It's no problem at all. I'm happy when someone is working on it. Your idea is good and when you're finished, I would be honored to adopt your changes if you want to :)
Otherwise, you can simply not merge to the upstream, but instead just create a branch with your new feature in your fork, for example. As long as you don't merge it to the upstream, nobody will notice and the changes will only be in your Github repo.
Here are two small overviews of how pull requests work:
@./how-to-fork-modify-and-create-pull-requests-on-github-242a02c49821
https://gun.io/news/2024/11/a-complete-guide-to-github-forks-from-setup-to-pull-requests/

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Oliver,Thanks.I will review the links you sent and attempt to create a new branch with my changes and let you know when I've tested it.Best regards,...DennyOn Jan 10, 2025, at 2:17 AM, Oliver Köster ***@***.***> wrote: It's no problem at all. I'm happy when someone is working on it. Your idea is good and when you're finished, I would be honored to adopt your changes if you want to :) Otherwise, you can simply not merge to the upstream, but instead just create a branch with your new feature in your fork, for example. As long as you don't merge it to the upstream, nobody will notice and the changes will only be in your Github repo. Here are two small overviews of how pull requests work: ***@***.***/how-to-fork-modify-and-create-pull-requests-on-github-242a02c49821 https://gun.io/news/2024/11/a-complete-guide-to-github-forks-from-setup-to-pull-requests/ —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
dennislia commented 2025-01-20 15:59:10 -06:00 (Migrated from github.com)
Copy Link

Hi Oliver,

I am pretty much finished with getting BLTouch with New Menu to work on my 4MAX Pro 2.0.

I have created a branch, off of the Fork that I made off your code, and released builds for just the 4MAX BLT versions at https://github.com/dennislia/Marlin-2-0-x-Anycubic-i3-MEGA-S-Fork/tree/new-special-menu . Wiki at https://github.com/dennislia/Marlin-2-0-x-Anycubic-i3-MEGA-S-Fork/wiki .

If you are interested in reviewing and considering adopting the changes, I’d appreciate your comments and recommendations.

Note: I think that every line that I touched I added “//dsl” so that all my changes could easily be found by Find-In-Files.
6 files were changed: platformio.ini (forgot to add "//dsl"), Configuration_adv.h, Configuration.h, Version.h, anycubic_touchscreen.cpp and any cubic_touchscreen.h. I changed a lot of the macro definitions to be consistent with the new screen menu selections text.

Thanks for your support.

Best Regards,
Denny

On Jan 10, 2025, at 11:28 AM, Dennis Lia @.***> wrote:

Oliver,

Thanks.

I will review the links you sent and attempt to create a new branch with my changes and let you know when I've tested it.

Best regards,

...Denny

On Jan 10, 2025, at 2:17 AM, Oliver Köster @.***> wrote:



It's no problem at all. I'm happy when someone is working on it. Your idea is good and when you're finished, I would be honored to adopt your changes if you want to :)

Otherwise, you can simply not merge to the upstream, but instead just create a branch with your new feature in your fork, for example. As long as you don't merge it to the upstream, nobody will notice and the changes will only be in your Github repo.

Here are two small overviews of how pull requests work:

@.***/how-to-fork-modify-and-create-pull-requests-on-github-242a02c49821

https://gun.io/news/2024/11/a-complete-guide-to-github-forks-from-setup-to-pull-requests/

—
Reply to this email directly, view it on GitHub https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/pull/563#issuecomment-2581943911, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4SZTJAFVHP6S5XYQRJKZGT2J5X2NAVCNFSM6AAAAABU5OER7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRHE2DGOJRGE.
You are receiving this because you modified the open/close state.

Hi Oliver, I am pretty much finished with getting BLTouch with New Menu to work on my 4MAX Pro 2.0. I have created a branch, off of the Fork that I made off your code, and released builds for just the 4MAX BLT versions at https://github.com/dennislia/Marlin-2-0-x-Anycubic-i3-MEGA-S-Fork/tree/new-special-menu . Wiki at https://github.com/dennislia/Marlin-2-0-x-Anycubic-i3-MEGA-S-Fork/wiki . If you are interested in reviewing and considering adopting the changes, I’d appreciate your comments and recommendations. Note: I think that every line that I touched I added “//dsl” so that all my changes could easily be found by Find-In-Files. 6 files were changed: platformio.ini (forgot to add "//dsl"), Configuration_adv.h, Configuration.h, Version.h, anycubic_touchscreen.cpp and any cubic_touchscreen.h. I changed a lot of the macro definitions to be consistent with the new screen menu selections text. Thanks for your support. Best Regards, Denny > On Jan 10, 2025, at 11:28 AM, Dennis Lia ***@***.***> wrote: > > Oliver, > > Thanks. > > I will review the links you sent and attempt to create a new branch with my changes and let you know when I've tested it. > > Best regards, > > ...Denny > >> On Jan 10, 2025, at 2:17 AM, Oliver Köster ***@***.***> wrote: >> >>  >> >> It's no problem at all. I'm happy when someone is working on it. Your idea is good and when you're finished, I would be honored to adopt your changes if you want to :) >> >> Otherwise, you can simply not merge to the upstream, but instead just create a branch with your new feature in your fork, for example. As long as you don't merge it to the upstream, nobody will notice and the changes will only be in your Github repo. >> >> Here are two small overviews of how pull requests work: >> >> ***@***.***/how-to-fork-modify-and-create-pull-requests-on-github-242a02c49821 >> >> https://gun.io/news/2024/11/a-complete-guide-to-github-forks-from-setup-to-pull-requests/ >> >> — >> Reply to this email directly, view it on GitHub <https://github.com/knutwurst/Marlin-2-0-x-Anycubic-i3-MEGA-S/pull/563#issuecomment-2581943911>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4SZTJAFVHP6S5XYQRJKZGT2J5X2NAVCNFSM6AAAAABU5OER7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRHE2DGOJRGE>. >> You are receiving this because you modified the open/close state. >>

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something in the Firmware isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
new feature
New feature or request
question
Further information is requested
stale-closing-soon
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
wp
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wp/Marlin-2-0-x-Anycubic-i3-MEGA-S#563
No description provided.
Delete Branch "master-dsl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?