Commit Graph

236 Commits

Author SHA1 Message Date
Justin Schiff 1cd2ed7b4c Use CLAMP macro instead 2021-05-15 13:52:45 -04:00
Justin Schiff a48dab6ef5 Uses strtol instead of atoi so that we can properly handle errors.
This now handles overflow and underflow correctly, by parsing the string
and then clamping the value between INT_MIN and INT_MAX. `atoi` was
giving us garbage values when the buffer overflowed.

Fixes #408
2021-05-15 13:52:45 -04:00
okaestne 5b769045f0 Fix crashes when no documents (tabs) are open
Two crashes are possible:

1. Fixes #450 (toggle overview map without any open tabs/docs)
2. Pressing ESC (e.g. to close searchbar) without any tabs open
2021-04-30 13:24:57 -04:00
okaestne 5b7c1d936e Implement #225: Options to render whitespace
Add preferences to enable displaying whitespace (tabs, spaces, nbsp and newlines).
Options allow to choose locations (leading, inside text, trailing) of whitespace to display and to disable rendering of newline chars.
2021-04-30 12:19:18 -04:00
Soapux 423f214a70 Fix permissions 2021-02-22 11:18:08 -05:00
Eli Schwartz 3940e04530 fixup! cleanup: remove code dropped in commit 67892da099
Also drop function that is now unused once the previous unused code got
removed.
2020-12-14 08:39:04 -05:00
Eli Schwartz 76b2fcba7b remove never-used variable added in commit 9e805380d4 2020-12-01 20:15:26 -05:00
Eli Schwartz d41e63a340 cleanup: remove code dropped in commit 67892da099 2020-12-01 20:15:26 -05:00
Michael Webster 9e805380d4 Add XAppFavorites support to the file menu.
This adds a Favorites submenu, and it moves the recent list into
a submenu.

See:
c9c885a841
2020-11-11 23:21:51 -05:00
JosephMcc 3bf1b62a34 xed-highlight-mode-dialog/selector: Clean up code style
Fix a few indentation errors and convert tabs to spaces.
2020-09-22 09:45:17 -04:00
JosephMcc a71e7eea3a xed-highlight-mode-selector.c: Fix a couple of missing casts 2020-09-07 10:26:08 -04:00
JosephMcc 7e6a888e1d Clean up remaining deprecated preprocessor commands 2020-09-07 10:25:40 -04:00
JosephMcc 3ca66d6fb6 Port to Gtksourceview4
This allows us access to some newer fixes since the older version is no
longer being worked on.

Fixes: https://github.com/linuxmint/xed/issues/395
2020-08-27 17:59:37 +02:00
icarter09 385d32dbfc Added JoinLines plugin. Removed logic to split lines. Moved Join Line shortcut from Layout to Editing section. 2020-04-23 10:37:40 -04:00
icarter09 6f58fd2f2c Added wait entry to man page. Removed logic that cause wait to open extra tab. 2020-04-10 09:50:19 -04:00
icarter09 b6483090b6 Changed shortcut window to be non-model. 2020-04-06 11:54:19 -04:00
Isaac Carter 6bbcc343dd
Fixed memory issue found by valgrind (#366) 2020-04-06 07:34:48 -07:00
icarter09 45bcb345e8 Added logic to check if the focus need to be set. Squashed formatting commits. 2020-03-11 12:27:33 -04:00
icarter09 d1833f6591 Added logic to support using replace all across documents. 2020-03-11 11:54:44 -04:00
icarter09 8a98e18511 Created new section for the Word Wrap shortcut. Increased height attribute to fit new section so a new page is not created. 2020-03-11 11:46:50 -04:00
icarter09 5a16a65643 Created initial test dir. Created File menu test.
Added test for Help menu.

Created test case for Toolbar.

Updated meson build for test. Removed unnecessary file.
2020-02-06 13:28:45 -05:00
Stephen Collins d5a48be670 Add settings widget to the prefs dialog for the implicit newline setting
The setting was already available in the schema and implemented in xed itself, but wasn't exposed in the preferences dialog.
2020-01-07 23:22:32 -05:00
Michael Webster 4eaddc1cb7 xed-tab-label.c: Apply tab tooltip to the box containing the tab's
label and icon, regression from 808e77b052.
2019-12-16 11:34:39 -05:00
Stephen Collins 808e77b052 xed-tab-label.c: remove unused event box preventing scroll events
It doesn't seem to do anything except intercept scroll events, which are used to switch tabs.
2019-12-16 11:03:04 -05:00
Stephen Collins 55e386beef Disable the comments action when not supported to avoid confusion 2019-12-16 10:37:30 -05:00
Clement Lefebvre 3e37213b5e Print preview: Reuse existing msgid 2019-11-22 12:11:17 +00:00
Michael Webster 8763fbf5df print-preview: add a print button to the preview toolbar, to immediately
print the previewed document.
2019-11-05 20:07:35 -05:00
Clement Lefebvre 54978e6e8f Preferences: Make dialog slightly taller 2019-07-23 12:11:14 +02:00
Alexander Drozdov f4c882e3b5 Automatically open new Xed window on current workspace... (#319)
...if it wasn't already opened. Otherwise, open new tab
in Xed window on current Workspace.

Fix regression #318
2019-07-10 11:24:52 +02:00
Stephen Collins 52ee1591f7 Prevent a warning when closing the window while print preview is open (#315)
The warning was caused by the preview trying to save print settings
after the settings object was cleared. Clearing the settings object
in *_finalize instead of *_dispose fixes the issue.
2019-06-23 14:23:08 +02:00
Stephen Collins dde92eecbf Simplify an if statement. The logic is identical, but easier to read (#314) 2019-06-20 09:29:36 -07:00
Stephen Collins 7bdc217e8c Tab width popup: only select a menu item when the menu is open (#311)
This fixes a gdk window assertion error that occurs every time xed
is opened, as well as causes the correct menu item to actually be
selected as expected (it currently isn't).
2019-06-15 01:21:57 -07:00
Stephen Collins 2520d1c087 Remove deprecated call to gtk_widget_override_background_color (#299)
This was an override that no longer seems necessary and is causing
deprecation warnings.
2019-05-13 00:32:52 -07:00
Stephen Collins 116bfc2ac1 Remove references to deprecated GTK_STOCK_* (#298) 2019-05-13 00:32:34 -07:00
Stephen Collins 17062aaa18 Fix stuttering and disappearing of the toolbar when fullscreen (#300)
This fixes an issue where moving the mouse along the top edge of the
screen while fullscreened will cause a leave event to be triggered,
even though the mouse pointer is still inside the event box. This
caused the toolbar to disappear and/or stutter while moving the mouse
along the top edge.
2019-05-13 00:23:03 -07:00
Stephen Collins aa7dabad39 Search: replace a few functions that were deprecated in Gtk 3.22 (#297)
gtk_source_search_context_forward_finish,
gtk_source_search_context_backward_finish, and
gtk_source_search_context_replace
were replaced with
gtk_source_search_context_forward_finish2,
gtk_source_search_context_backward_finish2, and
gtk_source_search_context_replace2
respectively.
2019-05-08 02:34:06 -07:00
Stephen Collins 15ec9b4e65 Print preview: remove a couple calls to gtk_adjustment_value_changed (#296)
This function is no longer needed as the "value-changed" signal is
automatically emitted whenever the value changes (since Gtk 3.18).
2019-05-08 02:29:29 -07:00
Stephen Collins e7328ad12e print job: replace some deprecated font button functions (#294)
Replaces gtk_font_button_*et_font_name with gtk_font_chooser_*et_font
2019-05-08 02:08:22 -07:00
Stephen Collins 4044529191 Add toggle comment and toggle comment block actions w/ keybindings (#290) 2019-05-05 10:27:11 +01:00
Stephen Collins 992ca7a3ec print preview: fix logic for forward button sensitivity (#292)
Previously, the logic used to set the sensitivity of the forward
navigation button failed to consider when multiple pages are shown.
This resulted in the forward button being sensitive in some cases,
even if all pages, or the last page were shown. With this commit, it
is now updated properly.

Also, when the rows and columns are changed, the current page is now
changed to the nearest multiple of rows*cols so that the current page
is still shown, but navigating back to the beginning and then forward
again will be consistent.
2019-05-05 10:26:58 +01:00
Stephen Collins 67892da099 Fix some deprecation warnings (#289)
* xed-app.c: replace get_active_window with gtk_application version

This allows us to remove quite a bit of code, some of which uses
deprecated functions, so it also has the benefit of cleaning up the
deprecation warnings a bit.

* Switch a couple uses of gtk_show_uri with gtk_show_uri_on_window

gtk_show_uri is deprecated.

* Taglist plugin: remove call to gtk_tree_view_set_rules_hint

This function is deprecated, and it already defaults to false in
any case, so it wasn't doing anything anyway.

* Deprecations: move all instances of gtk_menu_popup to newer methods

In a couple cases this simplifies the code quite a bit

* Replace deprecated gdk_window_at_pointer with newer method
2019-05-05 10:25:37 +01:00
JosephMcc 2ebff67c9c xed-notebook: Always show the main notebook tabs (#285)
We were only showing the tabs when more than one file was open. When
fullscreen this leaves no indication of the current file having been modified
if there is only one. Instead just set them to show at all times.

Closes: https://github.com/linuxmint/xed/issues/152
2019-05-05 10:21:18 +01:00
JosephMcc 43ee0436d8 xed-window: Fix the tabs/spaces label in the statusbar (#283)
This was broken in the commit that added the new highlight mode selection
dialog. Get it working again.
2019-05-05 10:20:53 +01:00
Stephen Collins 2e3f337e84 print preview: fix layout drawing for 1X2 and 2X1 layouts (#291)
The indices were backwards, which was causing incorrect layout, and
scrolling issues at larger zoom levels.
2019-05-03 16:19:49 +01:00
JosephMcc d208cae3bc cleanup: Remove an unused Makefile.am (#280)
We build with Meson now so don't need this
2019-03-25 15:35:46 +00:00
JosephMcc 05b68fb5f5 statusbar: Fix the menu button styling (#281)
This was broken in 7ce2a750db (diff-d114482c8758b92b9c56c95d18efe926)
2019-03-25 15:35:26 +00:00
Michael Webster b868ebde1c highlight mode window: Make activatable via shortcut (ctrl-shift-H),
focus the search entry by default, and allow Escape to cancel the
dialog from the search entry.

Fixes linuxmint/mint-19.1-beta#18
Fixes linuxmint/mint-19.1-beta#19
Fixes linuxmint/mint-19.1-beta#20
2018-12-09 00:07:15 -05:00
Clement Lefebvre 0ec63fc00e Fix merge issues
POTFILES.in and xed-window.c required a couple of changes
after the status selector PR was merged.
2018-11-19 11:30:51 +00:00
Clement Lefebvre 7ce2a750db Merge branch 'highlight-selector' of git://github.com/TomaszGasior/xed into TomaszGasior-highlight-selector 2018-11-19 11:16:20 +00:00
Stephen Collins 6e36dc4a5f Port to meson (#258)
* Port to meson

* plugin generation script: swtich to meson, update to python3, switch to libpeas, add some extra options, and cleanup

* clean up some build warnings

* kill xed-bugreport.sh with fire: it isn't used anymore, and probably doesn't even work

* update gzip command to avoid warnings on some systems and move appdata.xml to /usr/share/metainfo/ as that's where it's supposed to go now

* POTFILES.in: fix path that changed in the meson port, which was causing makepot to fail
2018-11-19 11:09:52 +00:00