The warning was caused by the preview trying to save print settings
after the settings object was cleared. Clearing the settings object
in *_finalize instead of *_dispose fixes the issue.
This fixes a gdk window assertion error that occurs every time xed
is opened, as well as causes the correct menu item to actually be
selected as expected (it currently isn't).
This fixes an issue where moving the mouse along the top edge of the
screen while fullscreened will cause a leave event to be triggered,
even though the mouse pointer is still inside the event box. This
caused the toolbar to disappear and/or stutter while moving the mouse
along the top edge.
gtk_source_search_context_forward_finish,
gtk_source_search_context_backward_finish, and
gtk_source_search_context_replace
were replaced with
gtk_source_search_context_forward_finish2,
gtk_source_search_context_backward_finish2, and
gtk_source_search_context_replace2
respectively.
Previously, the logic used to set the sensitivity of the forward
navigation button failed to consider when multiple pages are shown.
This resulted in the forward button being sensitive in some cases,
even if all pages, or the last page were shown. With this commit, it
is now updated properly.
Also, when the rows and columns are changed, the current page is now
changed to the nearest multiple of rows*cols so that the current page
is still shown, but navigating back to the beginning and then forward
again will be consistent.
* xed-app.c: replace get_active_window with gtk_application version
This allows us to remove quite a bit of code, some of which uses
deprecated functions, so it also has the benefit of cleaning up the
deprecation warnings a bit.
* Switch a couple uses of gtk_show_uri with gtk_show_uri_on_window
gtk_show_uri is deprecated.
* Taglist plugin: remove call to gtk_tree_view_set_rules_hint
This function is deprecated, and it already defaults to false in
any case, so it wasn't doing anything anyway.
* Deprecations: move all instances of gtk_menu_popup to newer methods
In a couple cases this simplifies the code quite a bit
* Replace deprecated gdk_window_at_pointer with newer method
We were only showing the tabs when more than one file was open. When
fullscreen this leaves no indication of the current file having been modified
if there is only one. Instead just set them to show at all times.
Closes: https://github.com/linuxmint/xed/issues/152
This is left over code from the gedit days, which we don't use, and
don't use. This also has the added benifit of removing at least 1
deprecation warning.
* Remove unused variables
Fixes the following warnings when building xed:
../plugins/filebrowser/xed-file-browser-plugin.c: In function ‘xed_file_browser_plugin_activate’:
../plugins/filebrowser/xed-file-browser-plugin.c:532:22: warning: unused variable ‘schema’ [-Wunused-variable]
GSettingsSchema *schema;
^~~~~~
../plugins/filebrowser/xed-file-browser-plugin.c:531:28: warning: unused variable ‘schema_source’ [-Wunused-variable]
GSettingsSchemaSource *schema_source;
^~~~~~~~~~~~~
* Remove an unused variable
Fixes the following warning when building xed:
../plugins/sort/xed-sort-plugin.c: In function ‘buffer_sort_lines’:
../plugins/sort/xed-sort-plugin.c:168:12: warning: variable ‘last_line’ set but not used [-Wunused-but-set-variable]
gchar *last_line = NULL;
^~~~~~~~~
* Remove an unused variable
Fixes the following warning when building xed:
../plugins/wordcompletion/xed-wordcompletion-plugin.c: In function ‘xed_wordcompletion_view_deactivate’:
../plugins/wordcompletion/xed-wordcompletion-plugin.c:306:34: warning: unused variable ‘provider’ [-Wunused-variable]
GtkSourceCompletionProvider *provider;
^~~~~~~~
* Remove an unused variable
Fixes the following warning when building xed:
../plugins/spell/xed-spell-plugin.c: In function ‘update_ui’:
../plugins/spell/xed-spell-plugin.c:495:24: warning: unused variable ‘buffer’ [-Wunused-variable]
GtkTextBuffer *buffer;
^~~~~~
Clement Lefebvre
Leigh Scott
Pavel Shlyak
nardholio
Michael Webster
Alexander Drozdov
Stephen Collins
JosephMcc
Eli Schwartz
chingyinwan123